[No QA] Docs updates for E/A#94899 Odometer tab-switch discard changes FAQ - #94959
Closed
MelvinBot wants to merge 1 commit into
Closed
[No QA] Docs updates for E/A#94899 Odometer tab-switch discard changes FAQ#94959MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Jules <Julesssss@users.noreply.github.com>
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://d1e22965.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
Definitely not necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs update for E/A#94899
PR #94899 adds a Discard changes? confirmation modal that appears when a user switches away from the Odometer tab in the Distance request flow with unsaved readings or images.
The Distance Expenses help article already documents the Odometer flow in detail (entering readings, attaching images, save-for-later), so this PR adds a single FAQ entry describing the new confirmation behavior.
What changed
Distance-Expenses.md, explaining:All UI labels (Discard changes?, Discard changes, Cancel, Odometer, GPS, Map, Manual) were verified against the source code:
src/languages/en.ts(discardChangesConfirmation) and the tab definitions in the PR.@Julesssss, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.